Make v3 room links backwards compatible #5107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhatahmad
commented
Mar 30, 2023
|
|
||
| export default function RoomIdRouter() { | ||
| const { roomId } = useParams(); | ||
| const regex = /(\w{3}-\w{3}-\w{3})(-\w{3})?/; |
There was a problem hiding this comment.
catches either 123-123-123-123 or 123-123-123
|
Kudos, SonarCloud Quality Gate passed!
|
scouillard
reviewed
Mar 30, 2023
| import DefaultErrorPage from './components/errors/DefaultErrorPage'; | ||
| import NotFoundPage from './components/errors/NotFoundPage'; | ||
|
|
||
| export default function RootBoundary() { | ||
| const error = useRouteError(); | ||
| const status = error?.response?.status || error?.status; |
scouillard
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4192